linux-kernel - Re: [PATCH] x86/entry/32: Fix entry_INT80

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151016194559.GB3590@pd.tnic>
Date:	Fri, 16 Oct 2015 21:45:59 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	Andy Lutomirski <luto@...nel.org>
Cc:	x86@...nel.org, linux-kernel@...r.kernel.org,
	Brian Gerst <brgerst@...il.com>,
	Denys Vlasenko <dvlasenk@...hat.com>
Subject: Re: [PATCH] x86/entry/32: Fix entry_INT80_32 to expect interrupts to
 be on

On Fri, Oct 16, 2015 at 11:47:11AM -0700, Andy Lutomirski wrote:
> When I rewrote entry_INT80_32, I thought that int80 was an interrupt
> gate.  It's a trap gate.  *facepalm*
> 
> Thanks to Brian Gerst for pointing out that it's better to change
> the entry code than to change the gate type.
> 
> Suggested-by: Brian Gerst <brgerst@...il.com>
> Reported-by: Borislav Petkov <bp@...e.de>
> Fixes: 150ac78d63af ("x86/entry/32: Switch INT80 to the new C syscall path")
> Signed-off-by: Andy Lutomirski <luto@...nel.org>
> ---
> 
> I can reproduce Borislav's warning with an appropriate .config, and this
> patch fixes it.  I removed the Tested-by, because it's not the same fix
> that Borislav tested.

You can re-add it. Looks good.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/