linux-kernel - Re: [PATCH] staging: comedi: fixed few coding style warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151017062243.GA26616@kroah.com>
Date:	Fri, 16 Oct 2015 23:22:43 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Sakshi Bansal <sakshi.april5@...il.com>
Cc:	jak@...-linux.org, marvin24@....de, ac100@...ts.launchpad.net,
	linux-tegra@...r.kernel.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: comedi: fixed few coding style warnings

On Wed, Oct 14, 2015 at 07:33:00PM +0530, Sakshi Bansal wrote:
> Fixed block comments usage of * on subsequent lines
> 
> Signed-off-by: Sakshi Bansal <sakshi.april5@...il.com>
> ---
>  drivers/staging/comedi/comedi.h        | 181 +++++++++++++++++++--------------
>  drivers/staging/comedi/comedi_pcmcia.h |   3 +-
>  drivers/staging/comedi/comedilib.h     |  26 ++---
>  3 files changed, 120 insertions(+), 90 deletions(-)
> 
> diff --git a/drivers/staging/comedi/comedi.h b/drivers/staging/comedi/comedi.h
> index 66edda1..31a43ee 100644
> --- a/drivers/staging/comedi/comedi.h
> +++ b/drivers/staging/comedi/comedi.h
> @@ -1,20 +1,20 @@
>  /*
> -    include/comedi.h (installed as /usr/include/comedi.h)
> -    header file for comedi
> + *  include/comedi.h (installed as /usr/include/comedi.h)
> + *  header file for comedi
>  
> -    COMEDI - Linux Control and Measurement Device Interface
> -    Copyright (C) 1998-2001 David A. Schleef <ds@...leef.org>
> + *  COMEDI - Linux Control and Measurement Device Interface
> + *  Copyright (C) 1998-2001 David A. Schleef <ds@...leef.org>
>  
> -    This program is free software; you can redistribute it and/or modify
> -    it under the terms of the GNU Lesser General Public License as published by
> -    the Free Software Foundation; either version 2 of the License, or
> -    (at your option) any later version.
> + *  This program is free software; you can redistribute it and/or modify
> + *  it under the terms of the GNU Lesser General Public License as published by
> + *  the Free Software Foundation; either version 2 of the License, or
> + *  (at your option) any later version.
>  

Why are you leaving the blank lines alone?  Either do it all or nothing,
what you are doing here is not correct at all :(

Hint, please leave these alone, there's nothing wrong with the existing
format.

sorry,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/