linux-kernel - Re: [PATCH] stm: add configfs dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151017062441.GA26793@kroah.com>
Date:	Fri, 16 Oct 2015 23:24:41 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Mathieu Poirier <mathieu.poirier@...aro.org>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] stm: add configfs dependency

On Sat, Oct 17, 2015 at 12:35:19AM +0200, Arnd Bergmann wrote:
> There are three new stm modules, all of which use configfs for configuration.
> If configfs is not part of the kernel, or is a loadable module while
> the stm driver is builtin, we get a link error like:
> 
> drivers/built-in.o: In function `stp_policy_node_drop':
> drivers/hwtracing/stm/policy.c:232: undefined reference to `config_item_put'
> drivers/built-in.o: In function `stp_policies_make':
> drivers/hwtracing/stm/policy.c:352: undefined reference to `config_group_init_type_name'
> drivers/built-in.o: In function `stp_policy_node_make':
> drivers/hwtracing/stm/policy.c:215: undefined reference to `config_group_init_type_name'
> 
> This adds explicit Kconfig dependencies to ensure configfs is present.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
> The patches are currently in Greg's char-misc tree, we should have
> this one in the same branch.
> 
> diff --git a/drivers/hwtracing/stm/Kconfig b/drivers/hwtracing/stm/Kconfig
> index 5a59a28cc3da..6df294fff1eb 100644
> --- a/drivers/hwtracing/stm/Kconfig
> +++ b/drivers/hwtracing/stm/Kconfig
> @@ -1,5 +1,6 @@
>  config STM
>  	tristate "System Trace Module devices"
> +	depends on CONFIGFS_FS

It's better to do a select here, like other drivers do, I have a patch
in my queue to do that, I'll queue it up now.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/