linux-kernel - Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant on the right side of test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABXAfNJ_Nawz9u0a1E+udNhHd7zTW3OF=fhnqtV8GCQQGrJpEQ@mail.gmail.com>
Date:	Mon, 19 Oct 2015 20:51:41 +0530
From:	punit vara <punitvara@...il.com>
To:	Larry Finger <Larry.Finger@...inger.net>
Cc:	Greg KH <gregkh@...uxfoundation.org>, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org, Julia Lawall <Julia.Lawall@...6.fr>,
	Sudip Mukherjee <sudipm.mukherjee@...il.com>,
	Dan Carpenter <dan.carpenter@...cle.com>
Subject: Re: [PATCH v2 4/4] Staging: rtl8712: fix warning for placing constant
 on the right side of test

On Mon, Oct 19, 2015 at 8:14 AM, Larry Finger <Larry.Finger@...inger.net> wrote:
> On 10/18/2015 09:00 PM, Greg KH wrote:
>>
>> On Sun, Oct 18, 2015 at 12:02:53PM +0530, punit vara wrote:
>>>
>>> One more thing I would like suggestion how can start switching this
>>> driver to LIB80211 ,MAC80211 ? Which is the first file I should focus
>>> ? Simultaneously I am trying to understand the flow of driver . I
>>> would like to know the start point  from where I can start doing small
>>> changes.
>>
>>
>> If you don't understand the wireless stack, I suggest you do some
>> research on it first, converting a driver to the in-kernel stack is a
>> _very_ difficult thing and not something that someone without any
>> experience in this area is going to be able to do easily.
>
>
> I second this suggestion. Your skill level is not nearly sufficient for this
> sort of task. Note that there is a group working on driver rtl8192su, which
> should be able to replace rtl8712u. The participants are very highly skilled
> wireless developers; however, they are having trouble. The internals of the
> Realtek chips are not revealed to anyone in any form other than the code
> they release.
>
> Larry
>
>


Thank you Larry  ,Tillman , Greg for your valuable suggestions. I am
interested to learn wireless stack .I have already read wireless wiki
documentation , sort of rtl8712 code , cfg80112  APIs . Yeah I agree
with you Greg and Larry that its _very_ difficult to thing to convert
driver in kernel and also rtl8712 has more files compare to others.
Anyway however difficult or tough it may be but I have to go through
it once to become highly skilled or good engineer . I would give it a
try even if I will fail I believe at least 1% of my knowledge will be
improved . More suggestions are welcome.

I have did

git remote add gregkh
http://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git

git pull gregkh

git rebase my_local_branch

I have got some conflicts .I can solve them but they are too many . I
am trying to solve it . After that I will soon resend this patch.

Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/