linux-kernel - Re: [PATCH 21/31] perf test: Enforce LLVM test, add kbuild test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151019152134.GB14297@danjae.kornet>
Date:	Tue, 20 Oct 2015 00:21:34 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Arnaldo Carvalho de Melo <acme@...hat.com>
Cc:	Wang Nan <wangnan0@...wei.com>, acme@...nel.org, ast@...mgrid.com,
	brendan.d.gregg@...il.com, a.p.zijlstra@...llo.nl,
	daniel@...earbox.net, dsahern@...il.com, hekuang@...wei.com,
	jolsa@...nel.org, lizefan@...wei.com,
	masami.hiramatsu.pt@...achi.com, paulus@...ba.org,
	linux-kernel@...r.kernel.org, pi3orama@....com, xiakaixu@...wei.com
Subject: Re: [PATCH 21/31] perf test: Enforce LLVM test, add kbuild test

Hi Arnaldo,

On Mon, Oct 19, 2015 at 12:53:12PM -0200, Arnaldo Carvalho de Melo wrote:
> Em Mon, Oct 19, 2015 at 11:42:31PM +0900, Namhyung Kim escreveu:
> > Hi,
> > 
> > On Wed, Oct 14, 2015 at 12:41:32PM +0000, Wang Nan wrote:
> > > This patch enforces existing LLVM test, makes it compile more than one
> > > BPF source file. The compiled results are stored, can be used for other
> > > testcases. Except the first testcase (named LLVM_TESTCASE_BASE), failures
> > > of other test cases are not considered as failure of the whole test.
> > > 
> > > Adds a kbuild testcase to check whether kernel headers can be correctly
> > > found.
> > > 
> > > For example:
> > > 
> > >  # perf test LLVM
> > > 
> > >    38: Test LLVM searching and compiling                        : (llvm.kbuild-dir can be fixed) Ok
> > 
> > IMHO it'd be better to keep the test result simply as either "Ok" or
> > "FAILED" and provide details with -v option.
> 
> "Skipped" looks more natural here, with the reason for it skipping being shown
> only with -v.

Agreed.

> 
> Ingo made some comments about 'perf test' output recently, have you read that?

Nop, sorry.  I'll check it (and it'd be great it you could give me the
link :)


> 
> > Anyway I found the tracepoint error message is annoying in the current
> 
> You mean all these warnings:
> 
> [root@zoo ~]# perf test "parse event" 
>  5: parse events tests                                       :  Warning: [sunrpc:xprt_lookup_rqst] function __builtin_constant_p not defined
>   Warning: [sunrpc:xprt_transmit] function __builtin_constant_p not defined
>   Warning: [sunrpc:xprt_complete_rqst] function __builtin_constant_p not defined
> <SNIP>
>   Warning: [xen:xen_mmu_set_pud] function sizeof not defined
>   Warning: [xen:xen_mmu_set_pgd] function sizeof not defined
>   Warning: [xen:xen_mmu_ptep_modify_prot_start] function sizeof not defined
>   Warning: [xen:xen_mmu_ptep_modify_prot_commit] function sizeof not defined
>  Ok
> [root@zoo ~]# 
> 
> i.e. making those warnings appear only under 'perf test -v'? Cool!

Will send the fix soon!

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/