linux-kernel - Re: [PATCH] usnix: correctly handle kzalloc return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151019162431.GA42659@DGOODELL-M-F02A.cisco.com>
Date:	Mon, 19 Oct 2015 11:24:32 -0500
From:	Dave Goodell <dgoodell@...co.com>
To:	Insu Yun <wuninsu@...il.com>
Cc:	umalhi@...co.com, dledford@...hat.com, sean.hefty@...el.com,
	hal.rosenstock@...il.com, linux-rdma@...r.kernel.org,
	linux-kernel@...r.kernel.org, taesoo@...ech.edu,
	yeongjin.jang@...ech.edu, insu@...ech.edu
Subject: Re: [PATCH] usnix: correctly handle kzalloc return value

On Sat, Oct 17, 2015 at 07:06:56PM +0000, Insu Yun wrote:
> Since kzalloc returns memory address, not error code,
> it should be checked whether it is null or not. 
> 
> Signed-off-by: Insu Yun <wuninsu@...il.com>
> ---
>  drivers/infiniband/hw/usnic/usnic_ib_qp_grp.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

The subject says "usnix" where it should say "usnic".  Otherwise:

Reviewed-by: Dave Goodell <dgoodell@...co.com>

If you have more of these fixes for drivers/infiniband/hw/usnic/, you
can send them all through just Doug Ledford and linux-rdma@, no need to
copy all of linux-kernel@.  You can also CC me instead of Upinder, whose
email bounces at this point, though I will see your patches sent to
linux-rdma@ even if I'm not explicitly CC-ed.  The patch to update
MAINTAINERS for usnic has been submitted but hasn't yet percolated
somewhere you would have seen it:

https://patchwork.kernel.org/patch/7410421/

-Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/