linux-kernel - Re: [PATCH] usnix: correctly handle kzalloc return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5627F91C.9050102@redhat.com>
Date:	Wed, 21 Oct 2015 16:44:12 -0400
From:	Doug Ledford <dledford@...hat.com>
To:	Insu Yun <wuninsu@...il.com>, umalhi@...co.com,
	sean.hefty@...el.com, hal.rosenstock@...il.com,
	linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:	taesoo@...ech.edu, yeongjin.jang@...ech.edu, insu@...ech.edu
Subject: Re: [PATCH] usnix: correctly handle kzalloc return value

On 10/17/2015 03:06 PM, Insu Yun wrote:
> Since kzalloc returns memory address, not error code,
> it should be checked whether it is null or not. 
> 
> Signed-off-by: Insu Yun <wuninsu@...il.com>

Thanks, applied.

> ---
>  drivers/infiniband/hw/usnic/usnic_ib_qp_grp.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/usnic/usnic_ib_qp_grp.c b/drivers/infiniband/hw/usnic/usnic_ib_qp_grp.c
> index db3588d..a678a66 100644
> --- a/drivers/infiniband/hw/usnic/usnic_ib_qp_grp.c
> +++ b/drivers/infiniband/hw/usnic/usnic_ib_qp_grp.c
> @@ -221,8 +221,8 @@ create_roce_custom_flow(struct usnic_ib_qp_grp *qp_grp,
>  
>  	/* Create Flow Handle */
>  	qp_flow = kzalloc(sizeof(*qp_flow), GFP_ATOMIC);
> -	if (IS_ERR_OR_NULL(qp_flow)) {
> -		err = qp_flow ? PTR_ERR(qp_flow) : -ENOMEM;
> +	if (!qp_flow) {
> +		err = -ENOMEM;
>  		goto out_dealloc_flow;
>  	}
>  	qp_flow->flow = flow;
> @@ -296,8 +296,8 @@ create_udp_flow(struct usnic_ib_qp_grp *qp_grp,
>  
>  	/* Create qp_flow */
>  	qp_flow = kzalloc(sizeof(*qp_flow), GFP_ATOMIC);
> -	if (IS_ERR_OR_NULL(qp_flow)) {
> -		err = qp_flow ? PTR_ERR(qp_flow) : -ENOMEM;
> +	if (!qp_flow) {
> +		err = -ENOMEM;
>  		goto out_dealloc_flow;
>  	}
>  	qp_flow->flow = flow;
> 


-- 
Doug Ledford <dledford@...hat.com>
              GPG KeyID: 0E572FDD



Download attachment "signature.asc" of type "application/pgp-signature" (885 bytes)