linux-kernel - Re: [PATCH] iscsi-target: return -ENOMEM instead of -1 in case of failed kmalloc()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56262872.1030302@dev.mellanox.co.il>
Date:	Tue, 20 Oct 2015 14:41:38 +0300
From:	Sagi Grimberg <sagig@....mellanox.co.il>
To:	Luis de Bethencourt <luisbg@....samsung.com>,
	linux-kernel@...r.kernel.org
Cc:	nab@...ux-iscsi.org, cvubrugier@...tmail.fm, sagig@...lanox.com,
	linux-scsi@...r.kernel.org, target-devel@...r.kernel.org
Subject: Re: [PATCH] iscsi-target: return -ENOMEM instead of -1 in case of
 failed kmalloc()

On 10/19/2015 11:18 PM, Luis de Bethencourt wrote:
> Smatch complains about returning hard coded error codes, silence this
> warning.
>
> drivers/target/iscsi/iscsi_target_parameters.c:211 iscsi_create_default_params() warn: returning -1 instead of -ENOMEM is sloppy
>
> Signed-off-by: Luis de Bethencourt <luisbg@....samsung.com>

Looks good,

Reviewed-by: Sagi Grimberg <sagig@...lanox.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/