linux-kernel - Re: [PATCH] iscsi-target: return -ENOMEM instead of -1 in case of failed kmalloc()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1447540273.18527.5.camel@haakon3.risingtidesystems.com>
Date:	Sat, 14 Nov 2015 14:31:13 -0800
From:	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>
To:	Luis de Bethencourt <luisbg@....samsung.com>
Cc:	linux-kernel@...r.kernel.org, cvubrugier@...tmail.fm,
	sagig@...lanox.com, linux-scsi@...r.kernel.org,
	target-devel@...r.kernel.org
Subject: Re: [PATCH] iscsi-target: return -ENOMEM instead of -1 in case of
 failed kmalloc()

Hi Luis,

Apologies for the delayed response.

On Mon, 2015-10-19 at 21:18 +0100, Luis de Bethencourt wrote:
> Smatch complains about returning hard coded error codes, silence this
> warning.
> 
> drivers/target/iscsi/iscsi_target_parameters.c:211 iscsi_create_default_params() warn: returning -1 instead of -ENOMEM is sloppy
> 
> Signed-off-by: Luis de Bethencourt <luisbg@....samsung.com>
> ---
> 
> Hi,
> 
> This doesn't change the functionality. It is just about using the more specific
> errno. And at the same time silencing smatch.
> 
> Thanks,
> Luis
> 
>  drivers/target/iscsi/iscsi_target_parameters.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 

Applied to target-pending/queue-fixes.

Thank you,

--nab


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/