linux-kernel - Re: [PATCH 00/19] staging/wilc1000 cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4261822.eWDaN5tlMP@wuerfel>
Date:	Wed, 21 Oct 2015 12:53:48 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	glen lee <glen.lee@...el.com>
Cc:	linux-wireless@...r.kernel.org, Rachel Kim <rachel.kim@...el.com>,
	devel@...verdev.osuosl.org, Chris Park <chris.park@...el.com>,
	gregkh@...uxfoundation.org,
	Stanislav Kholmanskikh <kholmanskikh.s.s@...il.com>,
	Johnny Kim <johnny.kim@...el.com>,
	linux-kernel@...r.kernel.org, Tony Cho <tony.cho@...el.com>,
	Leo Kim <leo.kim@...el.com>
Subject: Re: [PATCH 00/19] staging/wilc1000 cleanups

On Wednesday 21 October 2015 19:06:52 glen lee wrote:
> Hi arnd,
> 
> Thanks for the all the patches. 
> About the patch ( use proper naming for global symbols ),
> We are planning to use this driver not only for wilc1000 but also for
> other atmel wireless driver. I'd appreciate if you could use wl instead of wilc1000.

Hmm, while I see that 'wilc1000' is too specific here, using just 'wl' might be
a little too general. The same namespace is used by drivers/mtd/ubi/wl.c,
drivers/net/wireless/brcm80211/brcmfmac/cfg80211.c, and a number of local
identifiers in other drivers.

Would 'wilc' work as a prefix for all devices you are interested in here?

> And the global variable g_linux_wlan will be placed in netdevice private data
> and finally it will be removed. I already posted some of those patches.

Ok, so we need to coordinate a bit here. My patches also go in that direction
and remove the global variables from linux_wlan_sdio.c and linux_wlan_spi.c,
but did not remove the one from linux_wlan.c, because doing that depends on
the last [RFC] patch in my series, and I felt I had spent enough time on it
at that point ;-)

Would you be ok with taking my patches and rebasing them on top of yours
with the changes you want,  or do you need help from me with that?

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/