linux-kernel - Re: [PATCH v8 1/5] configfs: Allow dynamic group creation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151022084034.GA21923@lst.de>
Date:	Thu, 22 Oct 2015 10:40:34 +0200
From:	Christoph Hellwig <hch@....de>
To:	Daniel Baluta <daniel.baluta@...el.com>
Cc:	jic23@...nel.org, jlbec@...lplan.org, linux-iio@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, lars@...afoo.de, knaack.h@....de,
	linux-kernel@...r.kernel.org, octavian.purdila@...el.com,
	pebolle@...cali.nl, patrick.porlan@...el.com,
	adriana.reus@...el.com, constantin.musca@...el.com,
	marten@...uitiveaerial.com, cristina.opriceana@...il.com,
	pmeerw@...erw.net, hch@....de, viro@...iv.linux.org.uk,
	akpm@...ux-foundation.org
Subject: Re: [PATCH v8 1/5] configfs: Allow dynamic group creation

On Tue, Oct 20, 2015 at 01:53:42PM +0300, Daniel Baluta wrote:
> We don't want to hardcode default groups at subsystem
> creation time. We export:
> 	* configfs_register_group
> 	* configfs_unregister_group
> to allow drivers to programatically create/destroy groups
> later, after module init time.
> 
> This is needed for IIO configfs support.

This looks like a good start, and maybe we should merge it as is given
that merge window is about to end.  But I have two requests, one trivial
and one not so:

 a) please provide kerneldoc comments for the new functions
 b) just pass the name and item type and dynamically allocate the
    actua group. With that we can avoid a lot of boilerplate code and
    could also replace the horrible static sized defaults_groups array
    in current users with your new function.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/