linux-kernel - Re: [PATCH v8 1/5] configfs: Allow dynamic group creation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEnQRZC-6TV4Sk3YPshJoB+eBukZBOGzC5xM0QT9cVxJFBc+xw@mail.gmail.com>
Date:	Thu, 22 Oct 2015 11:59:07 +0300
From:	Daniel Baluta <daniel.baluta@...el.com>
To:	Christoph Hellwig <hch@....de>
Cc:	Daniel Baluta <daniel.baluta@...el.com>,
	Jonathan Cameron <jic23@...nel.org>,
	Joel Becker <jlbec@...lplan.org>,
	"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
	linux-fsdevel@...r.kernel.org,
	Lars-Peter Clausen <lars@...afoo.de>,
	Hartmut Knaack <knaack.h@....de>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"octavian.purdila@...el.com" <octavian.purdila@...el.com>,
	Paul Bolle <pebolle@...cali.nl>, patrick.porlan@...el.com,
	Adriana Reus <adriana.reus@...el.com>,
	constantin.musca@...el.com, marten@...uitiveaerial.com,
	Cristina Georgiana Opriceana <cristina.opriceana@...il.com>,
	Peter Meerwald <pmeerw@...erw.net>, viro@...iv.linux.org.uk,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v8 1/5] configfs: Allow dynamic group creation

On Thu, Oct 22, 2015 at 11:40 AM, Christoph Hellwig <hch@....de> wrote:
> On Tue, Oct 20, 2015 at 01:53:42PM +0300, Daniel Baluta wrote:
>> We don't want to hardcode default groups at subsystem
>> creation time. We export:
>>       * configfs_register_group
>>       * configfs_unregister_group
>> to allow drivers to programatically create/destroy groups
>> later, after module init time.
>>
>> This is needed for IIO configfs support.
>
> This looks like a good start, and maybe we should merge it as is given
> that merge window is about to end.  But I have two requests, one trivial
> and one not so:
>
>  a) please provide kerneldoc comments for the new functions
>  b) just pass the name and item type and dynamically allocate the
>     actua group. With that we can avoid a lot of boilerplate code and
>     could also replace the horrible static sized defaults_groups array
>     in current users with your new function.

Will try to see how quick I can do this. Eventually we can introduce the new
function + use it in IIO and fix current users later.

Thanks Christoph!

Daniel.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/