lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 22 Oct 2015 13:03:10 -0400 From: Mike Snitzer <snitzer@...hat.com> To: Ming Lin <mlin@...nel.org> Cc: linux-kernel@...r.kernel.org, Christoph Hellwig <hch@....de>, Jens Axboe <axboe@...nel.dk>, "Martin K. Petersen" <martin.petersen@...cle.com>, Kent Overstreet <kent.overstreet@...il.com> Subject: Re: block: re-add discard_granularity and alignment checks On Thu, Oct 22 2015 at 12:59pm -0400, Ming Lin <mlin@...nel.org> wrote: > From: Ming Lin <ming.l@....samsung.com> > > In commit b49a087("block: remove split code in > blkdev_issue_{discard,write_same}"), discard_granularity and alignment > checks were removed. Ideally, with bio late splitting, the upper layers > shouldn't need to depend on device's limits. > > Christoph reported a discard regression on the HGST Ultrastar SN100 NVMe > device when mkfs.xfs. We have not found the root cause yet. > > This patch re-adds discard_granularity and alignment checks by reverting > the related changes in commit b49a087. The good thing is now we can > remove the 2G discard size cap and just use UINT_MAX to avoid bi_size > overflow. > > Reviewed-by: Christoph Hellwig <hch@....de> > Tested-by: Christoph Hellwig <hch@....de> > Signed-off-by: Ming Lin <ming.l@....samsung.com> Reviewed-by: Mike Snitzer <snitzer@...hat.com> Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists