linux-kernel - Re: [PATCH] tools lib traceevent: Support %ps/%pS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151022130729.7b0c17ee@gandalf.local.home>
Date:	Thu, 22 Oct 2015 13:07:29 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:	Scott Wood <scottwood@...escale.com>,
	<linux-kernel@...r.kernel.org>, Dave Chinner <david@...morbit.com>
Subject: Re: [PATCH] tools lib traceevent: Support %ps/%pS


This fell through the abyss of my INBOX.

Arnaldo, can you take this.

Acked-by: Steven Rostedt <rostedt@...dmis.org>

-- Steve


On Mon, 31 Aug 2015 16:16:37 -0500
Scott Wood <scottwood@...escale.com> wrote:

> Commits such as 65dd297ac25565 ("xfs: %pF is only for function
> pointers") caused a regression because pretty_print() didn't support
> %ps/%pS.  The current %pf/%pF implementation in pretty_print() is what
> %ps/%pS is supposed to do, so use the same code for %ps/%pS.
> 
> Addressing the incorrect %pf/%pF implementation is beyond the scope of
> this patch.
> 
> Signed-off-by: Scott Wood <scottwood@...escale.com>
> ---
>  tools/lib/traceevent/event-parse.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
> index cc25f05..f05e5b0 100644
> --- a/tools/lib/traceevent/event-parse.c
> +++ b/tools/lib/traceevent/event-parse.c
> @@ -4761,8 +4761,8 @@ static void pretty_print(struct trace_seq *s, void *data, int size, struct event
>  				else
>  					ls = 2;
>  
> -				if (*(ptr+1) == 'F' ||
> -				    *(ptr+1) == 'f') {
> +				if (*(ptr+1) == 'F' || *(ptr+1) == 'f' ||
> +				    *(ptr+1) == 'S' || *(ptr+1) == 's') {
>  					ptr++;
>  					show_func = *ptr;
>  				} else if (*(ptr+1) == 'M' || *(ptr+1) == 'm') {

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/