[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <562F48C2.1070803@linux.vnet.ibm.com>
Date: Tue, 27 Oct 2015 10:49:54 +0100
From: Peter Oberparleiter <oberpar@...ux.vnet.ibm.com>
To: "James E.J. Bottomley" <JBottomley@...n.com>
Cc: Vasu Dev <vasu.dev@...el.com>, stable@...r.kernel.org,
linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
Hannes Reinecke <hare@...e.de>,
Bart Van Assche <bvanassche@....org>
Subject: [RESEND PATCH] scsi_sysfs: Fix queue_ramp_up_period return code
Writing a number to /sys/bus/scsi/devices/<sdev>/queue_ramp_up_period
returns the value of that number instead of the number of bytes written.
This behavior can confuse programs expecting POSIX write() semantics.
Fix this by returning the number of bytes written instead.
Signed-off-by: Peter Oberparleiter <oberpar@...ux.vnet.ibm.com>
Reviewed-by: Hannes Reinecke <hare@...e.de>
Cc: stable@...r.kernel.org
---
drivers/scsi/scsi_sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c
index b333389..6b0f292 100644
--- a/drivers/scsi/scsi_sysfs.c
+++ b/drivers/scsi/scsi_sysfs.c
@@ -898,7 +898,7 @@ sdev_store_queue_ramp_up_period(struct device *dev,
return -EINVAL;
sdev->queue_ramp_up_period = msecs_to_jiffies(period);
- return period;
+ return count;
}
static DEVICE_ATTR(queue_ramp_up_period, S_IRUGO | S_IWUSR,
--
2.3.0
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists