linux-kernel - Re: [RESEND PATCH] scsi_sysfs: Fix queue_ramp_up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <12B06B0F-E672-439E-A7F0-5B8F77BF3358@linux.vnet.ibm.com>
Date:	Wed, 28 Oct 2015 17:12:17 -0500
From:	"Matthew R. Ochs" <mrochs@...ux.vnet.ibm.com>
To:	Peter Oberparleiter <oberpar@...ux.vnet.ibm.com>
Cc:	"James E.J. Bottomley" <JBottomley@...n.com>,
	Vasu Dev <vasu.dev@...el.com>, stable@...r.kernel.org,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
	Hannes Reinecke <hare@...e.de>,
	Bart Van Assche <bvanassche@....org>
Subject: Re: [RESEND PATCH] scsi_sysfs: Fix queue_ramp_up_period return code

> On Oct 27, 2015, at 4:49 AM, Peter Oberparleiter <oberpar@...ux.vnet.ibm.com> wrote:
> 
> Writing a number to /sys/bus/scsi/devices/<sdev>/queue_ramp_up_period
> returns the value of that number instead of the number of bytes written.
> This behavior can confuse programs expecting POSIX write() semantics.
> Fix this by returning the number of bytes written instead.
> 
> Signed-off-by: Peter Oberparleiter <oberpar@...ux.vnet.ibm.com>
> Reviewed-by: Hannes Reinecke <hare@...e.de>
> Cc: stable@...r.kernel.org
> ---
> drivers/scsi/scsi_sysfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c
> index b333389..6b0f292 100644
> --- a/drivers/scsi/scsi_sysfs.c
> +++ b/drivers/scsi/scsi_sysfs.c
> @@ -898,7 +898,7 @@ sdev_store_queue_ramp_up_period(struct device *dev,
> 		return -EINVAL;
> 
> 	sdev->queue_ramp_up_period = msecs_to_jiffies(period);
> -	return period;
> +	return count;
> }
> 
> static DEVICE_ATTR(queue_ramp_up_period, S_IRUGO | S_IWUSR,

Reviewed-by: Matthew R. Ochs <mrochs@...ux.vnet.ibm.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/