linux-kernel - Re: [PATCH 08/10] staging: fsl-mc: Fixed bug in dprc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151027100407.GB7340@mwanda>
Date:	Tue, 27 Oct 2015 13:04:07 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	"J. German Rivera" <German.Rivera@...escale.com>
Cc:	gregkh@...uxfoundation.org, arnd@...db.de,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	bhamciu1@...escale.com, jiang.liu@...ux.intel.com,
	bhupesh.sharma@...escale.com, agraf@...e.de,
	stuart.yoder@...escale.com, nir.erez@...escale.com,
	itai.katz@...escale.com, marc.zyngier@....com,
	scottwood@...escale.com, lijun.pan@...escale.com,
	leoli@...escale.com, R89243@...escale.com,
	richard.schmitt@...escale.com
Subject: Re: [PATCH 08/10] staging: fsl-mc: Fixed bug in dprc_probe() error
 path

On Mon, Oct 26, 2015 at 10:49:19AM -0500, J. German Rivera wrote:
> -error_cleanup_open:
> +dprc_scan_container_error:
>  	(void)dprc_close(mc_dev->mc_io, 0, mc_dev->mc_handle);

The error label was better in the original code.  A "goto
error_cleanup_open", that tells you what the goto does.  "goto
dprc_scan_container_error" tells you nothing because you can see from
the line before that there was a container error.  No new information.
It's just like a function name tells you what a function does.  You
wouldn't name the function called_from_main().

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/