linux-kernel - Re: [PATCH v10] gpio: Add GPIO support for the ACCES 104-IDIO-16

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdbQyed0S0Y6MSt35LuOekFprvbPMDpsGku-cBXBt=9j0Q@mail.gmail.com>
Date:	Tue, 27 Oct 2015 11:06:58 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	William Breathitt Gray <vilhelm.gray@...il.com>,
	Andreas Bofjall <andreas@...onk.org>,
	Simon Guinot <simon.guinot@...uanux.org>,
	Diego Elio Pettenò <flameeyes@...meeyes.eu>,
	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	Daniel Krueger <daniel.krueger@...tec-electronic.com>,
	Bruno Randolf <br1@...fach.org>,
	Vivien Didelot <vivien.didelot@...oirfairelinux.com>
Cc:	Alexandre Courbot <gnurou@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH v10] gpio: Add GPIO support for the ACCES 104-IDIO-16

On Mon, Oct 19, 2015 at 6:59 PM, William Breathitt Gray
<vilhelm.gray@...il.com> wrote:

> The ACCES 104-IDIO-16 family of PC/104 utility boards feature 16
> optically isolated inputs and 16 optically isolated FET solid state
> outputs. This driver provides GPIO support for these 32 channels of
> digital I/O. Change-of-State detection interrupts are not supported.
>
> GPIO 0-15 correspond to digital outputs 0-15, while GPIO 16-31
> correspond to digital inputs 0-15. The base port address for the device
> may be set via the idio_16_base module parameter.
>
> Signed-off-by: William Breathitt Gray <vilhelm.gray@...il.com>
> ---
> Changes in v10:
>   - Rename symbols to be more concise
>   - Allocate GPIO device private data structure in probe function

Yes, exactly like this. :)

Patcha applied for kernel v4.4.

> +menu "ISA GPIO drivers"
> +
> +config GPIO_104_IDIO_16
> +       tristate "ACCES 104-IDIO-16 GPIO support"
> +       depends on X86
> +       help
> +         Enables GPIO support for the ACCES 104-IDIO-16 family.
> +
> +endmenu

I have five other drivers using port-based I/O:

gpio-f7188x.c
gpio-it87.c
gpio-sch.c
gpio-sch311x.c
gpio-ts5500.c

Do you think it makes sense to move all of these in under
the "ISA GPIO drivers" menu as well? I guess they all require
ISA after all.

(Added their maintainers to the To: line so I can get some input
on this.)

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/