linux-kernel - Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <563095E1.9010406@samsung.com>
Date:	Wed, 28 Oct 2015 18:31:13 +0900
From:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
To:	Javier Martinez Canillas <javier@...hile0.org>,
	Lee Jones <lee.jones@...aro.org>
Cc:	Wolfram Sang <wsa@...-dreams.de>,
	Linus Walleij <linus.walleij@...aro.org>,
	Sebastian Reichel <sre@...nel.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Chanwoo Choi <cw00.choi@...sung.com>,
	Mark Brown <broonie@...nel.org>,
	Ben Dooks <ben-linux@...ff.org>, Joe Perches <joe@...ches.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag

On 28.10.2015 18:21, Javier Martinez Canillas wrote:
> Hello Lee,
> 

(...)
Let me only add something to certain part of your email...

>> But you aren't maintaining the driver i.e. you don't collect patches
>> and *maintain* them on an upstream branch.  Granted some of you guys
>> are doing a great job of maintaining branches on your downstream or
>> BSP kernels, but conduct a Reviewer type role for upstream.
>>
>> You guys are pushing back like this is some kind of demotion.  That's
>> not the case at all.  All it does is better describe the (very worthy)
>> function you *actually* provide.
>>
> 
> But I think it makes description less accurate in fact, since without
> $SUBJECT get_maintainers.pl reports for example:
> 
> Krzysztof Kozlowski <k.kozlowski@...sung.com> (supporter:MAXIM PMIC
> AND MUIC DRIVERS FOR EXYNOS BASED BO...)
> Lee Jones <lee.jones@...aro.org> (supporter:MULTIFUNCTION DEVICES (MFD))
> 
> and after the change:
> 
> Krzysztof Kozlowski <k.kozlowski@...sung.com> (reviewer)
> Lee Jones <lee.jones@...aro.org> (supporter:MULTIFUNCTION DEVICES (MFD))
> 
> He also works for Samsung so the driver is not only maintained but
> supported since he can actually take care of it as a part of his day
> job (if I understood correctly).

Oh, that's interesting semantic change. Yes, in that particular case, I
added the "supported" tag on purpose - it's part of my job. It is
connected with what I said in other reply - we have deep interest in
these drivers. Not only "I will review the code if I have the time". No.
I will devote my time to ensure that the code is working on our products.

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/