linux-kernel - [PATCH] ARM: fix bug in vdsomunge swab32 macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <130abb060734507d4affcf9d81b87ce6af5d2cc8.1446045045.git.hns@goldelico.com>
Date:	Wed, 28 Oct 2015 16:10:48 +0100
From:	"H. Nikolaus Schaller" <hns@...delico.com>
To:	Efraim Yawitz <efraim.yawitz@...il.com>,
	Szabolcs Nagy <szabolcs.nagy@....com>,
	Russell King <rmk+kernel@....linux.org.uk>,
	Nathan Lynch <nathan_lynch@...tor.com>,
	Will Deacon <will.deacon@....com>
Cc:	<linux-arm-kernel@...ts.infradead.org>,
	linux-kernel@...r.kernel.org, marek@...delico.com,
	"H. Nikolaus Schaller" <hns@...delico.com>
Subject: [PATCH] ARM: fix bug in vdsomunge swab32 macro

Commit Commit 8a603f91cc48 ("ARM: 8445/1: fix vdsomunge not to depend on glibc specific byteswap.h")

unfortunately introduced a bug created but not found during
discussion and patch simplification.

Reported-by: Efraim Yawitz <efraim.yawitz@...il.com>
Signed-off-by: H. Nikolaus Schaller <hns@...delico.com>
---
 arch/arm/vdso/vdsomunge.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/vdso/vdsomunge.c b/arch/arm/vdso/vdsomunge.c
index 0cebd98..f645527 100644
--- a/arch/arm/vdso/vdsomunge.c
+++ b/arch/arm/vdso/vdsomunge.c
@@ -66,7 +66,7 @@
 	((((x) & 0x000000ff) << 24) | \
 	 (((x) & 0x0000ff00) <<  8) | \
 	 (((x) & 0x00ff0000) >>  8) | \
-	 (((x) & 0xff000000) << 24))
+	 (((x) & 0xff000000) >> 24))
 
 #if __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__
 #define HOST_ORDER ELFDATA2LSB
-- 
2.5.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/