linux-kernel - Re: [PATCH v10] gpio: Add GPIO support for the ACCES 104-IDIO-16

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZBnmE2F7i2PYuxvO4cpYsGnrcGr0HMKg9WAPVMGnDBTw@mail.gmail.com>
Date:	Wed, 28 Oct 2015 16:11:41 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Mika Westerberg <mika.westerberg@...ux.intel.com>
Cc:	William Breathitt Gray <vilhelm.gray@...il.com>,
	Andreas Bofjall <andreas@...onk.org>,
	Simon Guinot <simon.guinot@...uanux.org>,
	Diego Elio Pettenò <flameeyes@...meeyes.eu>,
	Daniel Krueger <daniel.krueger@...tec-electronic.com>,
	Bruno Randolf <br1@...fach.org>,
	Vivien Didelot <vivien.didelot@...oirfairelinux.com>,
	Alexandre Courbot <gnurou@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH v10] gpio: Add GPIO support for the ACCES 104-IDIO-16

On Tue, Oct 27, 2015 at 5:51 PM, Mika Westerberg
<mika.westerberg@...ux.intel.com> wrote:
> On Tue, Oct 27, 2015 at 05:42:23PM +0100, Linus Walleij wrote:
>> On Tue, Oct 27, 2015 at 3:23 PM, Mika Westerberg
>> <mika.westerberg@...ux.intel.com> wrote:
>> > On Tue, Oct 27, 2015 at 11:06:58AM +0100, Linus Walleij wrote:
>> >> > +menu "ISA GPIO drivers"
>> >> > +
>> >> > +config GPIO_104_IDIO_16
>> >> > +       tristate "ACCES 104-IDIO-16 GPIO support"
>> >> > +       depends on X86
>> >> > +       help
>> >> > +         Enables GPIO support for the ACCES 104-IDIO-16 family.
>> >> > +
>> >> > +endmenu
>> >>
>> >> I have five other drivers using port-based I/O:
>> >>
>> >> gpio-f7188x.c
>> >> gpio-it87.c
>> >> gpio-sch.c
>> >> gpio-sch311x.c
>> >> gpio-ts5500.c
>> >>
>> >> Do you think it makes sense to move all of these in under
>> >> the "ISA GPIO drivers" menu as well? I guess they all require
>> >> ISA after all.
>> >>
>> >> (Added their maintainers to the To: line so I can get some input
>> >> on this.)
>> >
>> > Not all of them actually require ISA. For example gpio-sch is part of an
>> > MFD device which is a PCI device. PCI bus also has notion of I/O ports.
>>
>> Hm, is there a more fitting symbol we should sort it under, which
>> means thingofabob-that-has-portmapped I/O?
>
> Well, there's already "Memory mapped GPIO drivers" so how about "I/O
> mapped GPIO drivers"?

Sure, "Port-mapped I/O GPIO drivers"

But what should I put as "depends" for that submenu, that is maybe
the real question.

Would (ISA || PCI) suffice?

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/