lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20151028015141.GA11237@localhost> Date: Tue, 27 Oct 2015 18:51:41 -0700 From: Dmitry Torokhov <dmitry.torokhov@...il.com> To: Michael Welling <mwelling@...e.org> Cc: Tony Lindgren <tony@...mide.com>, Pavel Machek <pavel@....cz>, Felipe Balbi <balbi@...com>, Sebastian Reichel <sre@...nel.org>, Roger Quadros <rogerq@...com>, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-input@...r.kernel.org Subject: Re: [PATCH v2] Input: tsc2005 - Add support for tsc2004 Hi Michael, On Tue, Oct 27, 2015 at 07:17:01PM -0500, Michael Welling wrote: > Adds support for the i2c based tsc2004. Support was added to the tsc2005 driver > due to the similarity of the devices. > > Signed-off-by: Michael Welling <mwelling@...e.org> > --- > v2: Fixes Kconfig based on report for 0-day build bot. > > .../bindings/input/touchscreen/tsc2004.txt | 38 ++++ > drivers/input/touchscreen/Kconfig | 7 +- > drivers/input/touchscreen/tsc2005.c | 206 ++++++++++++++++----- Could we maybe split the code into core, spi and i2c drivers instead of keeping everything together and rely on #ifdefs? Thanks! -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists