linux-kernel - Re: block: re-add discard_granularity and alignment checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 28 Oct 2015 09:13:59 +0900
From:	Jens Axboe <axboe@...nel.dk>
To:	Ming Lin <mlin@...nel.org>, Mike Snitzer <snitzer@...hat.com>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	Christoph Hellwig <hch@....de>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Kent Overstreet <kent.overstreet@...il.com>
Subject: Re: block: re-add discard_granularity and alignment checks

On 10/28/2015 06:23 AM, Ming Lin wrote:
> On Thu, Oct 22, 2015 at 10:03 AM, Mike Snitzer <snitzer@...hat.com> wrote:
>> On Thu, Oct 22 2015 at 12:59pm -0400,
>> Ming Lin <mlin@...nel.org> wrote:
>>
>>> From: Ming Lin <ming.l@....samsung.com>
>>>
>>> In commit b49a087("block: remove split code in
>>> blkdev_issue_{discard,write_same}"), discard_granularity and alignment
>>> checks were removed. Ideally, with bio late splitting, the upper layers
>>> shouldn't need to depend on device's limits.
>>>
>>> Christoph reported a discard regression on the HGST Ultrastar SN100 NVMe
>>> device when mkfs.xfs. We have not found the root cause yet.
>>>
>>> This patch re-adds discard_granularity and alignment checks by reverting
>>> the related changes in commit b49a087. The good thing is now we can
>>> remove the 2G discard size cap and just use UINT_MAX to avoid bi_size
>>> overflow.
>>>
>>> Reviewed-by: Christoph Hellwig <hch@....de>
>>> Tested-by: Christoph Hellwig <hch@....de>
>>> Signed-off-by: Ming Lin <ming.l@....samsung.com>
>>
>> Reviewed-by: Mike Snitzer <snitzer@...hat.com>
>
> Hi Jens,
>
> Would you please take this one?

I was going to add it for 4.3, but hch just pointed out that it's a 
regression in this series. I'll send it in for 4.3.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/