linux-kernel - Re: [PATCH 01/12] usb: xhci: expose xhci extended capabilities via debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56317402.502@linux.intel.com>
Date:	Thu, 29 Oct 2015 09:18:58 +0800
From:	"Lu, Baolu" <baolu.lu@...ux.intel.com>
To:	Oliver Neukum <oneukum@...e.com>
Cc:	Mathias Nyman <mathias.nyman@...el.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Alan Stern <stern@...land.harvard.edu>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/12] usb: xhci: expose xhci extended capabilities via
 debugfs



On 10/28/2015 05:27 PM, Oliver Neukum wrote:
>> +static int fill_buffer(struct debug_buffer *buf)
>> >+{
>> >+	int ret;
>> >+
>> >+	if (buf->output_buf)
>> >+		return -EINVAL;
>> >+
>> >+	buf->alloc_size = PAGE_SIZE;
>> >+	buf->output_buf = vmalloc(buf->alloc_size);
> That really makes no sense. If you allocate exactly
> PAGE_SIZE, you should allocate a page.

Yes, I will change it in v2.

>
> 	Regards
> 		Oliver

Thanks,
Baolu

>
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/