linux-kernel - Re: [PATCH 01/12] usb: xhci: expose xhci extended capabilities via debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <563174BA.9010307@linux.intel.com>
Date:	Thu, 29 Oct 2015 09:22:02 +0800
From:	"Lu, Baolu" <baolu.lu@...ux.intel.com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	Mathias Nyman <mathias.nyman@...el.com>,
	Alan Stern <stern@...land.harvard.edu>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/12] usb: xhci: expose xhci extended capabilities via
 debugfs



On 10/28/2015 08:40 PM, Greg Kroah-Hartman wrote:
>> >+struct debug_buffer {
>> >+	ssize_t (*fill_func)(struct debug_buffer *);
>> >+	struct usb_bus *bus;
>> >+	struct mutex mutex;
>> >+	size_t count;
>> >+	char *output_buf;
>> >+	size_t alloc_size;
>> >+};
>> >+
>> >+static const char *get_extcap_desc(u32 cap_id)
>> >+{
>> >+	switch (cap_id) {
>> >+	case XHCI_EXT_CAPS_LEGACY:
>> >+		return "USB Legacy Support";
>> >+	case XHCI_EXT_CAPS_PROTOCOL:
>> >+		return "Supported Protocol";
>> >+	case XHCI_EXT_CAPS_PM:
>> >+		return "Extended Power Management";
>> >+	case XHCI_EXT_CAPS_VIRT:
>> >+		return "I/O Virtualization (xHCI-IOV)";
>> >+	case XHCI_EXT_CAPS_ROUTE:
>> >+		return "Message Interrupt";
>> >+	case XHCI_EXT_CAPS_LOCALMEM:
>> >+		return "Local Memory";
>> >+	case XHCI_EXT_CAPS_DEBUG:
>> >+		return "USB Debug Capability";
> This is a lot more stuff than just debug port, it should be in sysfs
> as individual files, not one big one that you somehow have to parse in
> order to determine this information.
>

I will move it into sysfs in v2.

Thanks,
Baolu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/