linux-kernel - RE: [V5, 2/6] fsl/fman: Add FMan support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM2PR03MB509FB7052B8B0401369F9D5E6200@DM2PR03MB509.namprd03.prod.outlook.com>
Date:	Thu, 29 Oct 2015 16:08:34 +0000
From:	Liberman Igal <Igal.Liberman@...escale.com>
To:	Scott Wood <scottwood@...escale.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Madalin-Cristian Bucur <madalin.bucur@...escale.com>
Subject: RE: [V5, 2/6] fsl/fman: Add FMan support


Regards,
Igal Liberman

> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Thursday, October 29, 2015 5:25 PM
> To: Liberman Igal-B31950 <Igal.Liberman@...escale.com>
> Cc: netdev@...r.kernel.org; linuxppc-dev@...ts.ozlabs.org; linux-
> kernel@...r.kernel.org; Bucur Madalin-Cristian-B32716
> <madalin.bucur@...escale.com>
> Subject: Re: [V5, 2/6] fsl/fman: Add FMan support
> 
> On Thu, 2015-10-29 at 10:22 -0500, Liberman Igal-B31950 wrote:
> > Regards,
> > Igal Liberman
> >
> > > -----Original Message-----
> > > From: Wood Scott-B07421
> > > Sent: Wednesday, October 28, 2015 11:31 PM
> > > To: Liberman Igal-B31950 <Igal.Liberman@...escale.com>
> > > Cc: netdev@...r.kernel.org; linuxppc-dev@...ts.ozlabs.org; linux-
> > > kernel@...r.kernel.org; Bucur Madalin-Cristian-B32716
> > > <madalin.bucur@...escale.com>
> > > Subject: Re: [V5, 2/6] fsl/fman: Add FMan support
> > >
> > > On Tue, 2015-10-27 at 11:32 -0500, Liberman Igal-B31950 wrote:
> > >
> > > > > > +
> > > > > > +struct device *fman_get_device(struct fman *fman) {  return
> > > > > > +fman->dev; }
> > > > >
> > > > > Is this really necessary?
> > > > >
> > > >
> > > > Fman port needs fman->dev, fman structure is opaque, so yes, it's
> > > > needed.
> > >
> > > Why is opacity being maintained from one part of the fman driver to
> > > another?
> > > Isn't this the sort of excessive layering that was complained about?
> > >
> > >
> >
> > It's not really layering.
> > Fman Port uses Fman resources, it's not completely standalone.
> 
> That's my point -- if it's not standalone, why is "struct fman" opaque to the
> port code?
> 

OK, I'll expose struct fman. 

> -Scott