linux-kernel - Re: [PATCH] sparc64: Fix numa distance values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151029185056.GA398@ravnborg.org>
Date:	Thu, 29 Oct 2015 19:50:56 +0100
From:	Sam Ravnborg <sam@...nborg.org>
To:	Nitin Gupta <nitin.m.gupta@...cle.com>
Cc:	sparclinux <sparclinux@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Chris Hyser <chris.hyser@...cle.com>,
	Khalid Aziz <khalid.aziz@...cle.com>,
	Joonsoo Kim <iamjoonsoo.kim@....com>,
	David Hildenbrand <dahi@...ux.vnet.ibm.com>,
	Tony Luck <tony.luck@...el.com>,
	Santosh Shilimkar <santosh.shilimkar@...cle.com>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sparc64: Fix numa distance values

Small nit.

> diff --git a/arch/sparc/include/asm/topology_64.h b/arch/sparc/include/asm/topology_64.h
> index 01d1704..ed3dfdd 100644
> --- a/arch/sparc/include/asm/topology_64.h
> +++ b/arch/sparc/include/asm/topology_64.h
> @@ -31,6 +31,9 @@ static inline int pcibus_to_node(struct pci_bus *pbus)
>  	 cpu_all_mask : \
>  	 cpumask_of_node(pcibus_to_node(bus)))
>  
> +extern int __node_distance(int, int);
We have dropped using "extern" for function prototypes.

> +#define node_distance(a, b) __node_distance(a, b)

And had this be written as:
#define node_distance node_distance
int node_distance(int, int);

Then there had been no need for the leadign underscores.

But as I said - only nits.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/