linux-kernel - Re: [PATCH] sparc64: Fix numa distance values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5632A1A9.9040301@oracle.com>
Date:	Thu, 29 Oct 2015 15:46:01 -0700
From:	Nitin Gupta <nitin.m.gupta@...cle.com>
To:	Sam Ravnborg <sam@...nborg.org>
Cc:	sparclinux <sparclinux@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Chris Hyser <chris.hyser@...cle.com>,
	Khalid Aziz <khalid.aziz@...cle.com>,
	Joonsoo Kim <iamjoonsoo.kim@....com>,
	David Hildenbrand <dahi@...ux.vnet.ibm.com>,
	Tony Luck <tony.luck@...el.com>,
	Santosh Shilimkar <santosh.shilimkar@...cle.com>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sparc64: Fix numa distance values

On 10/29/2015 11:50 AM, Sam Ravnborg wrote:
> Small nit.
>
>> diff --git a/arch/sparc/include/asm/topology_64.h b/arch/sparc/include/asm/topology_64.h
>> index 01d1704..ed3dfdd 100644
>> --- a/arch/sparc/include/asm/topology_64.h
>> +++ b/arch/sparc/include/asm/topology_64.h
>> @@ -31,6 +31,9 @@ static inline int pcibus_to_node(struct pci_bus *pbus)
>>   	 cpu_all_mask : \
>>   	 cpumask_of_node(pcibus_to_node(bus)))
>>
>> +extern int __node_distance(int, int);
> We have dropped using "extern" for function prototypes.
>

ok, dropped extern here.

>> +#define node_distance(a, b) __node_distance(a, b)
>
> And had this be written as:
> #define node_distance node_distance

underscores here to separate macro name from function name
seems to be clearer and would also avoid confusing
cross-referencing tools.

> int node_distance(int, int);
>
> Then there had been no need for the leadign underscores.
>
> But as I said - only nits.
>
> 	Sam
>
Thanks for the review.
Nitin


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/