linux-kernel - Re: [PATCH 2/3] freezer: get rid of the kthread freezer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201510302243.BOjZ7H2z%fengguang.wu@intel.com>
Date:	Fri, 30 Oct 2015 22:08:49 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Jiri Kosina <jikos@...nel.org>
Cc:	kbuild-all@...org,
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	Dave Chinner <david@...morbit.com>, Jan Kara <jack@...e.cz>,
	Christoph Hellwig <hch@....de>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Al Viro <viro@...IV.linux.org.uk>, Tejun Heo <tj@...nel.org>,
	Pavel Machek <pavel@....cz>, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH 2/3] freezer: get rid of the kthread freezer

Hi Jiri,

[auto build test WARNING on v4.3-rc7 -- if it's inappropriate base, please suggest rules for selecting the more suitable base]

url:    https://github.com/0day-ci/linux/commits/Jiri-Kosina/PM-vfs-use-filesystem-freezing-instead-of-kthread-freezer/20151030-215223
config: x86_64-randconfig-x011-10300134 (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   In file included from include/linux/fs.h:5:0,
                    from fs/jfs/jfs_txnmgr.c:45:
   fs/jfs/jfs_txnmgr.c: In function 'jfs_lazycommit':
>> include/linux/wait.h:57:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
     wait_queue_t name = __WAITQUEUE_INITIALIZER(name, tsk)
     ^
>> fs/jfs/jfs_txnmgr.c:2800:3: note: in expansion of macro 'DECLARE_WAITQUEUE'
      DECLARE_WAITQUEUE(wq, current);
      ^
--
   In file included from include/linux/mmzone.h:9:0,
                    from include/linux/gfp.h:5,
                    from include/linux/mm.h:9,
                    from include/linux/pagemap.h:7,
                    from fs/nilfs2/segment.c:24:
   fs/nilfs2/segment.c: In function 'nilfs_segctor_thread':
   include/linux/wait.h:935:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
     wait_queue_t name = {      \
     ^
>> include/linux/wait.h:941:27: note: in expansion of macro 'DEFINE_WAIT_FUNC'
    #define DEFINE_WAIT(name) DEFINE_WAIT_FUNC(name, autoremove_wake_function)
                              ^
>> fs/nilfs2/segment.c:2509:2: note: in expansion of macro 'DEFINE_WAIT'
     DEFINE_WAIT(wait);
     ^
--
   mm/vmscan.c: In function 'kswapd':
>> mm/vmscan.c:3454:8: warning: unused variable 'ret' [-Wunused-variable]
      bool ret;
           ^

vim +/DECLARE_WAITQUEUE +2800 fs/jfs/jfs_txnmgr.c

^1da177e Linus Torvalds    2005-04-16  2784  				sbi->commit_state &= ~IN_LAZYCOMMIT;
^1da177e Linus Torvalds    2005-04-16  2785  				/*
^1da177e Linus Torvalds    2005-04-16  2786  				 * Don't continue in the for loop.  (We can't
^1da177e Linus Torvalds    2005-04-16  2787  				 * anyway, it's unsafe!)  We want to go back to
^1da177e Linus Torvalds    2005-04-16  2788  				 * the beginning of the list.
^1da177e Linus Torvalds    2005-04-16  2789  				 */
^1da177e Linus Torvalds    2005-04-16  2790  				break;
^1da177e Linus Torvalds    2005-04-16  2791  			}
^1da177e Linus Torvalds    2005-04-16  2792  
^1da177e Linus Torvalds    2005-04-16  2793  			/* If there was nothing to do, don't continue */
^1da177e Linus Torvalds    2005-04-16  2794  			if (!WorkDone)
^1da177e Linus Torvalds    2005-04-16  2795  				break;
^1da177e Linus Torvalds    2005-04-16  2796  		}
^1da177e Linus Torvalds    2005-04-16  2797  		/* In case a wakeup came while all threads were active */
^1da177e Linus Torvalds    2005-04-16  2798  		jfs_commit_thread_waking = 0;
^1da177e Linus Torvalds    2005-04-16  2799  
^1da177e Linus Torvalds    2005-04-16 @2800  		DECLARE_WAITQUEUE(wq, current);
^1da177e Linus Torvalds    2005-04-16  2801  
^1da177e Linus Torvalds    2005-04-16  2802  		add_wait_queue(&jfs_commit_thread_wait, &wq);
^1da177e Linus Torvalds    2005-04-16  2803  		set_current_state(TASK_INTERRUPTIBLE);
^1da177e Linus Torvalds    2005-04-16  2804  		LAZY_UNLOCK(flags);
^1da177e Linus Torvalds    2005-04-16  2805  		schedule();
^1da177e Linus Torvalds    2005-04-16  2806  		remove_wait_queue(&jfs_commit_thread_wait, &wq);
91dbb4de Christoph Hellwig 2006-02-15  2807  	} while (!kthread_should_stop());
^1da177e Linus Torvalds    2005-04-16  2808  

:::::: The code at line 2800 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2

:::::: TO: Linus Torvalds <torvalds@...970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@...970.osdl.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (27388 bytes)