linux-kernel - Re: [PATCH 2/3] freezer: get rid of the kthread freezer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 30 Oct 2015 22:12:37 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Jiri Kosina <jikos@...nel.org>
Cc:	kbuild-all@...org,
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	Dave Chinner <david@...morbit.com>, Jan Kara <jack@...e.cz>,
	Christoph Hellwig <hch@....de>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Al Viro <viro@...IV.linux.org.uk>, Tejun Heo <tj@...nel.org>,
	Pavel Machek <pavel@....cz>, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH 2/3] freezer: get rid of the kthread freezer

Hi Jiri,

[auto build test WARNING on v4.3-rc7 -- if it's inappropriate base, please suggest rules for selecting the more suitable base]

url:    https://github.com/0day-ci/linux/commits/Jiri-Kosina/PM-vfs-use-filesystem-freezing-instead-of-kthread-freezer/20151030-215223
config: x86_64-randconfig-x017-10300134 (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   drivers/media/dvb-core/dvb_frontend.c: In function 'dvb_frontend_thread':
>> drivers/media/dvb-core/dvb_frontend.c:730:1: warning: label 'restart' defined but not used [-Wunused-label]
    restart:
    ^

vim +/restart +730 drivers/media/dvb-core/dvb_frontend.c

9239effd5 drivers/media/dvb-core/dvb_frontend.c     Mauro Carvalho Chehab 2015-01-06  714  	if (ret) {
9239effd5 drivers/media/dvb-core/dvb_frontend.c     Mauro Carvalho Chehab 2015-01-06  715  		/* FIXME: return an error if it fails */
9239effd5 drivers/media/dvb-core/dvb_frontend.c     Mauro Carvalho Chehab 2015-01-06  716  		dev_info(fe->dvb->device,
9239effd5 drivers/media/dvb-core/dvb_frontend.c     Mauro Carvalho Chehab 2015-01-06  717  			"proceeding with FE task\n");
8a26a258b drivers/media/dvb-core/dvb_frontend.c     Mauro Carvalho Chehab 2015-02-23  718  	} else if (fepriv->pipe_start_entity) {
135f9be91 drivers/media/dvb-core/dvb_frontend.c     Mauro Carvalho Chehab 2015-01-06  719  		ret = media_entity_pipeline_start(fepriv->pipe_start_entity,
135f9be91 drivers/media/dvb-core/dvb_frontend.c     Mauro Carvalho Chehab 2015-01-06  720  						  &fepriv->pipe);
135f9be91 drivers/media/dvb-core/dvb_frontend.c     Mauro Carvalho Chehab 2015-01-06  721  		if (ret)
135f9be91 drivers/media/dvb-core/dvb_frontend.c     Mauro Carvalho Chehab 2015-01-06  722  			return ret;
9239effd5 drivers/media/dvb-core/dvb_frontend.c     Mauro Carvalho Chehab 2015-01-06  723  	}
135f9be91 drivers/media/dvb-core/dvb_frontend.c     Mauro Carvalho Chehab 2015-01-06  724  #endif
9239effd5 drivers/media/dvb-core/dvb_frontend.c     Mauro Carvalho Chehab 2015-01-06  725  
04c56d0e5 drivers/media/dvb/dvb-core/dvb_frontend.c Andrew de Quincey     2006-07-10  726  	dvb_frontend_init(fe);
36cb557a2 drivers/media/dvb/dvb-core/dvb_frontend.c Andrew de Quincey     2006-01-09  727  
36cb557a2 drivers/media/dvb/dvb-core/dvb_frontend.c Andrew de Quincey     2006-01-09  728  	while (1) {
36cb557a2 drivers/media/dvb/dvb-core/dvb_frontend.c Andrew de Quincey     2006-01-09  729  		up(&fepriv->sem);	    /* is locked when we enter the thread... */
6591691b2 drivers/media/dvb/dvb-core/dvb_frontend.c Andrew Morton         2007-02-08 @730  restart:
94238e9b1 drivers/media/dvb/dvb-core/dvb_frontend.c Hans Verkuil          2011-08-27  731  		wait_event_interruptible_timeout(fepriv->wait_queue,
e42837bcd drivers/media/dvb/dvb-core/dvb_frontend.c Rafael J. Wysocki     2007-10-18  732  			dvb_frontend_should_wakeup(fe) || kthread_should_stop()
e42837bcd drivers/media/dvb/dvb-core/dvb_frontend.c Rafael J. Wysocki     2007-10-18  733  				|| freezing(current),
36cb557a2 drivers/media/dvb/dvb-core/dvb_frontend.c Andrew de Quincey     2006-01-09  734  			fepriv->delay);
8eec14295 drivers/media/dvb/dvb-core/dvb_frontend.c Herbert Poetzl        2007-02-08  735  
8eec14295 drivers/media/dvb/dvb-core/dvb_frontend.c Herbert Poetzl        2007-02-08  736  		if (kthread_should_stop() || dvb_frontend_is_exiting(fe)) {
36cb557a2 drivers/media/dvb/dvb-core/dvb_frontend.c Andrew de Quincey     2006-01-09  737  			/* got signal or quitting */
6ae232245 drivers/media/dvb-core/dvb_frontend.c     Juergen Lock          2012-12-23  738  			if (!down_interruptible(&fepriv->sem))

:::::: The code at line 730 was first introduced by commit
:::::: 6591691b259f9487f374f35c0c310aa220f829c6 V4L/DVB (5209): Kthread api conversion for dvb_frontend and av7110 fix

:::::: TO: akpm@...ux-foundation.org <akpm@...ux-foundation.org>
:::::: CC: Mauro Carvalho Chehab <mchehab@...radead.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (21521 bytes)