linux-kernel - RE: [PATCH v4 5/7] PCI: irqdomain: Look up IRQ domain by fwnode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM2PR0301MB123242391B393049EACC7A81AB2F0@DM2PR0301MB1232.namprd03.prod.outlook.com>
Date:	Fri, 30 Oct 2015 15:58:23 +0000
From:	Jake Oshins <jakeo@...rosoft.com>
To:	Andy Shevchenko <andy.shevchenko@...il.com>
CC:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	KY Srinivasan <kys@...rosoft.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
	"olaf@...fle.de" <olaf@...fle.de>,
	"apw@...onical.com" <apw@...onical.com>,
	Vitaly Kuznetsov <vkuznets@...hat.com>,
	"tglx@...hat.com" <tglx@...hat.com>,
	Haiyang Zhang <haiyangz@...rosoft.com>,
	"marc.zyngier@....com" <marc.zyngier@....com>,
	Jiang Liu <jiang.liu@...ux.intel.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>
Subject: RE: [PATCH v4 5/7] PCI: irqdomain: Look up IRQ domain by
 fwnode_handle

> -----Original Message-----
> From: Andy Shevchenko [mailto:andy.shevchenko@...il.com]
> Sent: Thursday, October 29, 2015 5:28 PM
> To: Jake Oshins <jakeo@...rosoft.com>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>; KY Srinivasan
> <kys@...rosoft.com>; linux-kernel@...r.kernel.org;
> devel@...uxdriverproject.org; olaf@...fle.de; apw@...onical.com; Vitaly
> Kuznetsov <vkuznets@...hat.com>; tglx@...hat.com; Haiyang Zhang
> <haiyangz@...rosoft.com>; marc.zyngier@....com; Jiang Liu
> <jiang.liu@...ux.intel.com>; Bjorn Helgaas <bhelgaas@...gle.com>; linux-
> pci@...r.kernel.org
> Subject: Re: [PATCH v4 5/7] PCI: irqdomain: Look up IRQ domain by
> fwnode_handle
> 
> On Fri, Oct 30, 2015 at 1:46 AM,  <jakeo@...rosoft.com> wrote:
> > From: Jake Oshins <jakeo@...rosoft.com>
> >
> > This patch adds a second way of finding an IRQ domain associated with
> > a root PCI bus.  After looking to see if one can be found through
> > the OF tree, it attempts to look up the IRQ domain through an
> > fwnode_handle stored in the pci_sysdata struct.
> 
> 
> > +#ifdef CONFIG_PCI_MSI_IRQ_DOMAIN
> > +       /*
> > +        * If no IRQ domain was found via the OF tree, try looking it up
> > +        * directly through the fwnode_handle.
> > +        */
> > +       if (!d) {
> > +               if (pci_fwnode(bus)) {
> 
> Isn't it the same to
> if (!d && pci_fwnode(bus))
>  d = ...
> 

Thanks.  I'll make this change and resend.

-- Jake Oshins