linux-kernel - RE: [PATCH v4 6/7] drivers:hv: Define the channel type for Hyper-V PCI Express pass-through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 30 Oct 2015 15:57:56 +0000
From:	Jake Oshins <jakeo@...rosoft.com>
To:	Andy Shevchenko <andy.shevchenko@...il.com>
CC:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	KY Srinivasan <kys@...rosoft.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
	"olaf@...fle.de" <olaf@...fle.de>,
	"apw@...onical.com" <apw@...onical.com>,
	Vitaly Kuznetsov <vkuznets@...hat.com>,
	"tglx@...hat.com" <tglx@...hat.com>,
	Haiyang Zhang <haiyangz@...rosoft.com>,
	"marc.zyngier@....com" <marc.zyngier@....com>,
	Jiang Liu <jiang.liu@...ux.intel.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>
Subject: RE: [PATCH v4 6/7] drivers:hv: Define the channel type for Hyper-V
 PCI Express pass-through

> -----Original Message-----
> From: Andy Shevchenko [mailto:andy.shevchenko@...il.com]
> Sent: Thursday, October 29, 2015 5:45 PM
> To: Jake Oshins <jakeo@...rosoft.com>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>; KY Srinivasan
> <kys@...rosoft.com>; linux-kernel@...r.kernel.org;
> devel@...uxdriverproject.org; olaf@...fle.de; apw@...onical.com; Vitaly
> Kuznetsov <vkuznets@...hat.com>; tglx@...hat.com; Haiyang Zhang
> <haiyangz@...rosoft.com>; marc.zyngier@....com; Jiang Liu
> <jiang.liu@...ux.intel.com>; Bjorn Helgaas <bhelgaas@...gle.com>; linux-
> pci@...r.kernel.org
> Subject: Re: [PATCH v4 6/7] drivers:hv: Define the channel type for Hyper-V
> PCI Express pass-through
> 
> >
> >  /*
> > + * PCI Express Pass Through
> > + * {44C4F61D-4444-4400-9D52-802E27EDE19F}
> > + */
> > +
> > +#define HV_PCIE_GUID \
> > +       .guid = { \
> > +                       0x1D, 0xF6, 0xC4, 0x44, 0x44, 0x44, 0x00, 0x44, \
> > +                       0x9D, 0x52, 0x80, 0x2E, 0x27, 0xED, 0xE1, 0x9F \
> > +               }
> 
> What about
> #include <linux/uuid.h>
> 
> UUID_LE(...)
> 
> And you may use uuid_le type instead of custom raw buffer.
> 

Thanks.  I was just following the form of all the others in this file.  I think that this was done to match up with the representation that's coming across the VM boundary from Windows.

I do very much appreciate the feedback, though,
Jake Oshins