linux-kernel - Re: [PATCH v4.3-rc7] be2iscsi : Fix bogus WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5633C4D4.8080008@linux.vnet.ibm.com>
Date:	Fri, 30 Oct 2015 14:28:20 -0500
From:	Manoj Kumar <manoj@...ux.vnet.ibm.com>
To:	tim.gardner@...onical.com, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Cc:	Jayamohan Kallickal <jayamohan.kallickal@...gotech.com>,
	Minh Tran <minh.tran@...gotech.com>,
	John Soni Jose <sony.john-n@...gotech.com>,
	"James E.J. Bottomley" <JBottomley@...n.com>
Subject: Re: [PATCH v4.3-rc7] be2iscsi : Fix bogus WARN_ON length check

Tim:

Reviewed-by: Manoj Kumar <manoj@...ux.vnet.ibm.com>

---
Manoj Kumar

On 10/30/2015 1:22 PM, tim.gardner@...onical.com wrote:
> From: Tim Gardner <tim.gardner@...onical.com>
>
> drivers/scsi/be2iscsi/be_main.c: In function 'be_sgl_create_contiguous':
> drivers/scsi/be2iscsi/be_main.c:3187:18: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]
>    WARN_ON(!length > 0);
>
> gcc version 5.2.1
>
> Cc: Jayamohan Kallickal <jayamohan.kallickal@...gotech.com>
> Cc: Minh Tran <minh.tran@...gotech.com>
> Cc: John Soni Jose <sony.john-n@...gotech.com>
> Cc: "James E.J. Bottomley" <JBottomley@...n.com>
> Signed-off-by: Tim Gardner <tim.gardner@...onical.com>
> ---
>   drivers/scsi/be2iscsi/be_main.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c
> index 7a6dbfb..5cdcd29 100644
> --- a/drivers/scsi/be2iscsi/be_main.c
> +++ b/drivers/scsi/be2iscsi/be_main.c
> @@ -3184,7 +3184,7 @@ be_sgl_create_contiguous(void *virtual_address,
>   {
>   	WARN_ON(!virtual_address);
>   	WARN_ON(!physical_address);
> -	WARN_ON(!length > 0);
> +	WARN_ON(!length);
>   	WARN_ON(!sgl);
>
>   	sgl->va = virtual_address;
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/