linux-kernel - Re: [PATCH v4.3-rc7] be2iscsi : Fix bogus WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <mqdbnbgxec5.fsf@linux-x5ow.site>
Date:	Fri, 30 Oct 2015 21:59:22 +0100
From:	Johannes Thumshirn <jthumshirn@...e.de>
To:	tim.gardner@...onical.com
Cc:	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
	Jayamohan Kallickal <jayamohan.kallickal@...gotech.com>,
	Minh Tran <minh.tran@...gotech.com>,
	John Soni Jose <sony.john-n@...gotech.com>,
	"James E.J. Bottomley" <JBottomley@...n.com>
Subject: Re: [PATCH v4.3-rc7] be2iscsi : Fix bogus WARN_ON length check

Hi Tim,
tim.gardner@...onical.com writes:

> From: Tim Gardner <tim.gardner@...onical.com>
>
> drivers/scsi/be2iscsi/be_main.c: In function 'be_sgl_create_contiguous':
> drivers/scsi/be2iscsi/be_main.c:3187:18: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]
>   WARN_ON(!length > 0);
>
> gcc version 5.2.1

This patch (or similar) was already posted on Oct 1 by Joel Stanley.
See http://comments.gmane.org/gmane.linux.scsi/105462

Thanks,
        Johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/