linux-kernel - Re: [PATCH v2] fs/block_dev.c: Remove WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56340117.5000103@kernel.dk>
Date:	Fri, 30 Oct 2015 17:45:27 -0600
From:	Jens Axboe <axboe@...nel.dk>
To:	Jeff Moyer <jmoyer@...hat.com>
Cc:	Vivek Goyal <vgoyal@...hat.com>, tj@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] fs/block_dev.c: Remove WARN_ON() when inode writeback
 fails

On 10/30/2015 09:34 AM, Jeff Moyer wrote:
> From: Vivek Goyal <vgoyal@...hat.com>
>
> If a block device is hot removed and later last reference to device
> is put, we try to writeback the dirty inode. But device is gone and
> that writeback fails.
>
> Currently we do a WARN_ON() which does not seem to be the right thing.
> Convert it to a ratelimited kernel warning.

Any concerns with putting this into 4.4 and marking it for stable? Would 
be awesome to have a "Fixes:" in here too.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/