linux-kernel - Re: [PATCH v2] fs/block_dev.c: Remove WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <x49r3k8qwh5.fsf@segfault.boston.devel.redhat.com>
Date:	Mon, 02 Nov 2015 09:58:30 -0500
From:	Jeff Moyer <jmoyer@...hat.com>
To:	Jens Axboe <axboe@...nel.dk>
Cc:	Vivek Goyal <vgoyal@...hat.com>, tj@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] fs/block_dev.c: Remove WARN_ON() when inode writeback fails

Jens Axboe <axboe@...nel.dk> writes:

> On 10/30/2015 09:34 AM, Jeff Moyer wrote:
>> From: Vivek Goyal <vgoyal@...hat.com>
>>
>> If a block device is hot removed and later last reference to device
>> is put, we try to writeback the dirty inode. But device is gone and
>> that writeback fails.
>>
>> Currently we do a WARN_ON() which does not seem to be the right thing.
>> Convert it to a ratelimited kernel warning.
>
> Any concerns with putting this into 4.4 and marking it for stable?

No, that sounds fine to me.

> Would be awesome to have a "Fixes:" in here too.

OK.  I don't know which commit introduced the problem.  Do you want
something like this?

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1196089
or
Fixes: https://www.redhat.com/archives/dm-devel/2015-June/msg00111.html

I know some folks don't like mailing list archive links in the commit
messages.

Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/