linux-kernel - Re: [PATCH 1/2] mfd: sec-core: Rename MFD and regulator names differently

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 1 Nov 2015 13:15:05 +0900
From:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
To:	Alim Akhtar <alim.akhtar@...sung.com>
Cc:	lee.jones@...aro.org, broonie@...nel.org,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] mfd: sec-core: Rename MFD and regulator names differently

2015-10-30 20:01 GMT+09:00 Alim Akhtar <alim.akhtar@...sung.com>:
> Currently S2MPSXX multifunction device is named as *-pmic,
> and this MFD also supports regulator as a one of its MFD cell which
> has the same name, which is a bit confusing.
>
> We did discussed different approaches about how the MFD and it
> cells need to be named here [1].
> Based in the discussion this patch rename MFD regulator name as
> *-regulator instead of current *-pmic.
>
> [1]-> https://lkml.org/lkml/2015/10/28/417
>
> Suggested-by: Lee Jones <lee.jones@...aro.org>
> Signed-off-by: Alim Akhtar <alim.akhtar@...sung.com>
> ---
>  drivers/mfd/sec-core.c |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Two comments from my side:
1. Lee already pointed issue with bisectability. This is a requirement.
2. What is missing in commit is the reason. Answer to question: Why?
The answer is in LKML discussion but it should be provided here - in
commit: because current naming is confusing and we want to sort it
out.

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/