linux-kernel - Re: [PATCH] mcb: Do not return zero on error path in mcb_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151102031511.GA21893@kroah.com>
Date:	Sun, 1 Nov 2015 19:15:11 -0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Johannes Thumshirn <morbidrsa@...il.com>
Cc:	Alexey Khoroshilov <khoroshilov@...ras.ru>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	ldv-project@...uxtesting.org
Subject: Re: [PATCH] mcb: Do not return zero on error path in mcb_pci_probe()

On Thu, Oct 22, 2015 at 09:28:57AM +0200, Johannes Thumshirn wrote:
> On Sat, Oct 17, 2015 at 11:33 PM, Alexey Khoroshilov
> <khoroshilov@...ras.ru> wrote:
> > There is an error path in mcb_pci_probe() where
> > it returns zero instead of error code.
> >
> > Found by Linux Driver Verification project (linuxtesting.org).
> >
> > Signed-off-by: Alexey Khoroshilov <khoroshilov@...ras.ru>
> > ---
> >  drivers/mcb/mcb-pci.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/mcb/mcb-pci.c b/drivers/mcb/mcb-pci.c
> > index 051645498b53..67d5e7d08df6 100644
> > --- a/drivers/mcb/mcb-pci.c
> > +++ b/drivers/mcb/mcb-pci.c
> > @@ -51,6 +51,7 @@ static int mcb_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> >         priv->mapbase = pci_resource_start(pdev, 0);
> >         if (!priv->mapbase) {
> >                 dev_err(&pdev->dev, "No PCI resource\n");
> > +               ret = -ENODEV;
> >                 goto out_disable;
> >         }
> >
> > --
> > 1.9.1
> >
> 
> Applied, thanks.
> 
> @Greg, shall I forward you the patch or do a pull request?

Please forward on, I don't do many pull requests.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/