linux-kernel - Re: [PATCH kernel] rcu: Fix comment for rcu_dereference_raw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20151102031530.GN4122@linux.vnet.ibm.com>
Date:	Sun, 1 Nov 2015 19:15:30 -0800
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Alexey Kardashevskiy <aik@...abs.ru>
Cc:	Steven Rostedt <rostedt@...dmis.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH kernel] rcu: Fix comment for rcu_dereference_raw_notrace

On Mon, Nov 02, 2015 at 01:21:47PM +1100, Alexey Kardashevskiy wrote:
> rcu_dereference_raw() calls indirectly rcu_read_lock_held() while
> rcu_dereference_raw_notrace() does not so fix the comment about the latter.
> 
> Signed-off-by: Alexey Kardashevskiy <aik@...abs.ru>

Good eyes!  Queued for 4.5, thank you!

							Thanx, Paul

> ---
>  include/linux/rcupdate.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/rcupdate.h b/include/linux/rcupdate.h
> index 581abf8..931d627 100644
> --- a/include/linux/rcupdate.h
> +++ b/include/linux/rcupdate.h
> @@ -760,7 +760,7 @@ static inline void rcu_preempt_sleep_check(void)
>   * The tracing infrastructure traces RCU (we want that), but unfortunately
>   * some of the RCU checks causes tracing to lock up the system.
>   *
> - * The tracing version of rcu_dereference_raw() must not call
> + * The no-tracing version of rcu_dereference_raw() must not call
>   * rcu_read_lock_held().
>   */
>  #define rcu_dereference_raw_notrace(p) __rcu_dereference_check((p), 1, __rcu)
> -- 
> 2.5.0.rc3
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/