linux-kernel - Re: [PATCH] x86/intel_cacheinfo: Fix LLC topology for AMD Fam17h systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <563911FB.9070405@amd.com>
Date:	Tue, 3 Nov 2015 13:58:51 -0600
From:	Aravind Gopalakrishnan <aravind.gopalakrishnan@....com>
To:	Borislav Petkov <bp@...en8.de>
CC:	kbuild test robot <lkp@...el.com>, <kbuild-all@...org>,
	<tglx@...utronix.de>, <mingo@...hat.com>, <hpa@...or.com>,
	<bp@...e.de>, <x86@...nel.org>, <sudeep.holla@....com>,
	<akpm@...ux-foundation.org>, <geliangtang@....com>,
	<tj@...nel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86/intel_cacheinfo: Fix LLC topology for AMD Fam17h
 systems

On 11/3/2015 1:52 PM, Borislav Petkov wrote:
> On Tue, Nov 03, 2015 at 01:41:53PM -0600, Aravind Gopalakrishnan wrote:
>> cpu_llc_id references should be wrapped under #ifdef CONFIG_SMP.
>>
>> Did that and kernel build worked with the attached config.
>>
>> Will send a V2 with the fix.
> Why aren't you doing all that figuring out what the llc_id is in
> amd_detect_cmp() which is already CONFIG_SMP ifdeffed?
>
> Which is where that code belongs anyway...
>

Since we needed to modify last level cache IDs, I thought 
init_amd_cacheinfo() might be a logical place to put it.

But you are right, makes sense to move it to amd_detect_cmp().
I'll do that in V2.

Thanks,
-Aravind.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/