linux-kernel - Re: [PATCH] mm: change tlb_finish

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <58D5B463-D8C3-40E2-A0B0-458DB1117338@gmail.com>
Date:	Wed, 4 Nov 2015 16:46:25 +0800
From:	yalin wang <yalin.wang2010@...il.com>
To:	Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
	Mel Gorman <mgorman@...e.de>,
	Johannes Weiner <hannes@...xchg.org>, riel@...hat.com,
	raindel@...lanox.com, willy@...ux.intel.com, boaz@...xistor.com,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: change tlb_finish_mmu() to be more simple


> On Nov 4, 2015, at 16:36, Sergey Senozhatsky <sergey.senozhatsky.work@...il.com> wrote:
> 
> On (11/04/15 15:35), yalin wang wrote:
> [..]
>> 
>> -	for (batch = tlb->local.next; batch; batch = next) {
>> -		next = batch->next;
>> +	for (batch = tlb->local.next; batch; batch = batch->next)
>> 		free_pages((unsigned long)batch, 0);
> 
> accessing `batch->next' after calling free_pages() on `batch'?
> 
> 		-ss
oh,  my mistake, my code is buggy here .

Thanks--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/