linux-kernel - Re: [PATCH 5/9] perf, tools, stat: Move noise/running printing into printout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151104084854.GG29671@krava.brq.redhat.com>
Date:	Wed, 4 Nov 2015 09:48:54 +0100
From:	Jiri Olsa <jolsa@...hat.com>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	jolsa@...nel.org, acme@...nel.org, mingo@...nel.org,
	linux-kernel@...r.kernel.org, Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 5/9] perf, tools, stat: Move noise/running printing into
 printout

On Mon, Nov 02, 2015 at 05:50:24PM -0800, Andi Kleen wrote:

SNIP

> @@ -729,32 +722,8 @@ static void print_counter_aggr(struct perf_evsel *counter, char *prefix)
>  	if (prefix)
>  		fprintf(output, "%s", prefix);
>  
> -	if (scaled == -1 || !counter->supported) {
> -		fprintf(output, "%*s%s",
> -			csv_output ? 0 : 18,
> -			counter->supported ? CNTR_NOT_COUNTED : CNTR_NOT_SUPPORTED,
> -			csv_sep);
> -		fprintf(output, "%-*s%s",
> -			csv_output ? 0 : unit_width,
> -			counter->unit, csv_sep);
> -		fprintf(output, "%*s",
> -			csv_output ? 0 : -25,
> -			perf_evsel__name(counter));

so this changed current 'not supported' output:

   <not supported>      stalled-cycles-frontend  
   <not supported>      stalled-cycles-backend   


into

                 0      stalled-cycles-frontend                                     
                 0      stalled-cycles-backend    #   0.00% backend cycles idle     

> -
> -		if (counter->cgrp)
> -			fprintf(output, "%s%s", csv_sep, counter->cgrp->name);

haven't tried with cgroup, but I think that removing
above hunk will not do any good to it..

jirka

> -
> -		print_running(avg_running, avg_enabled);
> -		fputc('\n', output);
> -		return;
> -	}
> -
>  	uval = avg * counter->scale;
> -	printout(-1, 0, counter, uval, prefix);
> -

SNIP
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/