linux-kernel - Re: [PATCH V6 1/1] usb:serial: Add Fintek F81532/534 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 5 Nov 2015 10:55:27 +0800
From:	Peter Hung <hpeter@...il.com>
To:	johan@...nel.org
Cc:	gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, tom_tsai@...tek.com.tw,
	peter_hong@...tek.com.tw,
	Peter Hung <hpeter+linux_kernel@...il.com>
Subject: Re: [PATCH V6 1/1] usb:serial: Add Fintek F81532/534 driver

Hi

Peter Hung 於 2015/11/3 上午 11:51 寫道:
> This driver is for Fintek F81532/F81534 USB to Serial Ports IC.
> Changelog:
> v6
>      1. Re-implement the write()/resume() function. Due to this device cant be
>         suitable with generic write(), we'll do the submit write URB when
>         write()/received tx empty/set_termios()/resume()
>      2. Logic/Phy Port mapping rewrite in f81534_port_probe() &
>         f81534_phy_to_logic_port().
>      3. Introduced "Port Hide" function. Some customer use F81532 reference
>         design for HW layout, but really use F81534 IC. We'll check
>         F81534_PORT_CONF_DISABLE_PORT flag with in uart mode field to do
>         port hide with port not used. It can be avoid end-user to use not
>         layouted port.
>      4. The 4x3 output-only open-drain pins for F81532/534 is designed for
>         control outer devices (with our EVB for examples, the 4 sets of pins
>         are designed to control transceiver mode). So we decide to implement
>         with gpiolib interface.

I need to do some improvements with senior advices, so I'll send
v7 patch when I modify & re-test the code complete.

Could you give me some roughly advices of this patch when you having
time.

Thanks for your help
-- 
With Best Regards,
Peter Hung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/