lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 04 Nov 2015 21:56:32 -0500 (EST) From: David Miller <davem@...emloft.net> To: jarod@...hat.com Cc: linux-kernel@...r.kernel.org, edumazet@...gle.com, j.vosburgh@...il.com, vfalico@...il.com, gospo@...ulusnetworks.com, jiri@...nulli.us, razor@...ckwall.org, mkubecek@...e.cz, alexander.duyck@...il.com, netdev@...r.kernel.org Subject: Re: [PATCH v2 net-next] net/core: ensure features get disabled on new lower devs From: Jarod Wilson <jarod@...hat.com> Date: Tue, 3 Nov 2015 23:09:32 -0500 > With moving netdev_sync_lower_features() after the .ndo_set_features > calls, I neglected to verify that devices added *after* a flag had been > disabled on an upper device were properly added with that flag disabled as > well. This currently happens, because we exit __netdev_update_features() > when we see dev->features == features for the upper dev. We can retain the > optimization of leaving without calling .ndo_set_features with a bit of > tweaking and a goto here. > > Fixes: fd867d51f889 ("net/core: generic support for disabling netdev features down stack") ... > Reported-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com> > Signed-off-by: Jarod Wilson <jarod@...hat.com> > --- > v2: Based on suggestions from Alex, and with not changing err to ret, this > patch actually becomes quite minimal and doesn't ugly up the code much. Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists