linux-kernel - Re: [RFC PATCH 2/7] spi: sunxi: remove redundant "depends on RESET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 5 Nov 2015 12:20:38 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	linux-spi@...r.kernel.org
Subject: Re: [RFC PATCH 2/7] spi: sunxi: remove redundant "depends on
 RESET_CONTROLLER"

On Thu, Nov 05, 2015 at 09:11:47PM +0900, Masahiro Yamada wrote:
> 2015-11-05 20:28 GMT+09:00 Mark Brown <broonie@...nel.org>:

> > The dependency is on ARCH_SUNXI || COMPILE_TEST which is not the same as
> > ARCH_SUNXI.

> The compile test of this driver should pass even if RESET_CONTROLLER
> is not defined.
> So, it does not matter for COMPILE_TEST.

If that is the case then the change here is that the dependency on
RESET_CONTROLLER is just redundant which isn't what the commit message
says.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)