| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1446729815-25473-1-git-send-email-van.freenix@gmail.com> Date: Thu, 5 Nov 2015 21:23:35 +0800 From: Peng Fan <van.freenix@...il.com> To: linux-kernel@...r.kernel.org Cc: van.freenix@...il.com, Lee Jones <lee.jones@...aro.org>, Arnd Bergmann <arnd@...db.de> Subject: [PATCH] mfd: syscon: check 'property' before of_node_put When 'property' is not NULL, of_parse_phandle will return the node pointer with refcount incremented. So when of_node_put, also need to check property. Signed-off-by: Peng Fan <van.freenix@...il.com> Cc: Lee Jones <lee.jones@...aro.org> Cc: Arnd Bergmann <arnd@...db.de> --- drivers/mfd/syscon.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c index 176bf0f..fab36bc 100644 --- a/drivers/mfd/syscon.c +++ b/drivers/mfd/syscon.c @@ -168,7 +168,9 @@ struct regmap *syscon_regmap_lookup_by_phandle(struct device_node *np, return ERR_PTR(-ENODEV); regmap = syscon_node_to_regmap(syscon_np); - of_node_put(syscon_np); + + if (property) + of_node_put(syscon_np); return regmap; } -- 1.8.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists