linux-kernel - Re: [PATCH] perf tools: Change FEATURE-DUMP to FEATURE-DUMP.libbpf for lib bpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151105132352.GO13236@kernel.org>
Date:	Thu, 5 Nov 2015 10:23:52 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	Yunlong Song <yunlong.song@...wei.com>
Cc:	a.p.zijlstra@...llo.nl, paulus@...ba.org, mingo@...hat.com,
	linux-kernel@...r.kernel.org, wangnan0@...wei.com,
	namhyung@...nel.org, ast@...nel.org,
	masami.hiramatsu.pt@...achi.com, kan.liang@...el.com,
	adrian.hunter@...el.com, jolsa@...nel.org, dsahern@...il.com
Subject: Re: [PATCH] perf tools: Change FEATURE-DUMP to FEATURE-DUMP.libbpf
 for lib bpf

Em Thu, Nov 05, 2015 at 02:56:34PM +0800, Yunlong Song escreveu:
> Commit ed63f34c026e9a60d17fa750ecdfe3f600d49393 ("perf tools: Make perf
> depend on libbpf") dynamically creates FEATURE-DUMP.libbpf during the
> perf building, but the .gitignore under tools/lib/bpf/ mistakes
> FEATURE-DUMP.libbpf for FEATURE-DUMP. Besides, the Makefile under
> tools/lib/bpf/ also mistakes FEATURE-DUMP.libbpf for FEATURE-DUMP, which
> causes that "make clean" will leave (or say create) FEATURE-DUMP.libbpf
> rather than remove FEATURE-DUMP.libbpf file.

Ok, so the cset that created files with a .libbpf suffix was this one:

  commit 65f041bee783
  Author: Arnaldo Carvalho de Melo <acme@...hat.com>
  Date:   Mon Sep 21 17:25:27 2015 -0300

    tools lib bpf: Use FEATURE_USER to allow building in the same dir as perf

-------

That has this tag:

    Fixes: 1b76c13e4b36 ("bpf tools: Introduce 'bpf' library and add bpf feature check")

---

The cset you mention, ed63f34c026e9a60d17fa750ecdfe3f600d49393, just
makes perf call the code introduced by 1b76c13e4b36 and fixed by
65f041bee783, i.e. you start noticing, when building perf, that those
files are created.

Anyway, fixing it up, thanks for the patch!

- Arnaldo
 
> Signed-off-by: Yunlong Song <yunlong.song@...wei.com>
> ---
>  tools/lib/bpf/.gitignore | 2 +-
>  tools/lib/bpf/Makefile   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/lib/bpf/.gitignore b/tools/lib/bpf/.gitignore
> index 812aeed..f81e549 100644
> --- a/tools/lib/bpf/.gitignore
> +++ b/tools/lib/bpf/.gitignore
> @@ -1,2 +1,2 @@
>  libbpf_version.h
> -FEATURE-DUMP
> +FEATURE-DUMP.libbpf
> diff --git a/tools/lib/bpf/Makefile b/tools/lib/bpf/Makefile
> index fc9af57..a3caaf3 100644
> --- a/tools/lib/bpf/Makefile
> +++ b/tools/lib/bpf/Makefile
> @@ -180,7 +180,7 @@ config-clean:
>  clean:
>  	$(call QUIET_CLEAN, libbpf) $(RM) *.o *~ $(TARGETS) *.a *.so $(VERSION_FILES) .*.d \
>  		$(RM) LIBBPF-CFLAGS
> -	$(call QUIET_CLEAN, core-gen) $(RM) $(OUTPUT)FEATURE-DUMP
> +	$(call QUIET_CLEAN, core-gen) $(RM) $(OUTPUT)FEATURE-DUMP.libbpf
>  
>  
>  
> -- 
> 1.8.5.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/