linux-kernel - Re: [PATCH 1/7] doc:bindings:Add document for mfd hi665x PMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151105140412.GG18409@sirena.org.uk>
Date:	Thu, 5 Nov 2015 14:04:12 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Chen Feng <puck.chen@...ilicon.com>
Cc:	w.f@...wei.com, sameo@...ux.intel.com, lee.jones@...aro.org,
	linux-kernel@...r.kernel.org, lgirdwood@...il.com,
	robh+dt@...nel.org, pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	joro@...tes.org, iommu@...ts.linux-foundation.org,
	haojian.zhuang@...aro.org, devicetree@...r.kernel.org,
	xuwei5@...ilicon.com, xuyiping@...ilicon.com,
	kong.kongxinwei@...ilicon.com, z.liuxinliang@...ilicon.com,
	yudongbin@...ilicon.com, weidong2@...ilicon.com,
	saberlily.xia@...ilicon.com, haojian.zhuang@...look.com,
	leo.yan@...aro.org, linuxarm@...wei.com, dan.zhao@...ilicon.com,
	peter.panshilin@...ilicon.com, qijiwen@...ilicon.com
Subject: Re: [PATCH 1/7] doc:bindings:Add document for mfd hi665x PMIC

On Thu, Nov 05, 2015 at 09:34:42PM +0800, Chen Feng wrote:

Please use subject lines matching the style for the subsystem.  This
makes it easier for people to identify relevant patches.

> +- #interrupt-cells: Should be 2, two cells are needed for irq.
> +- interrupt-controller: hi655x has internal IRQs (has own IRQ domain).
> +- pmu_irq_gpio: should be &gpio_pmu_irq_n, is the IRQ gpio of hi655x.

I'm not entirely sure what this is but it sounds worrying - why can you
not just use a normal interrupt specifier?  It also doesn't correspond
to the example:

> +Example:
> +	pmic: pmic@...00000 {
> +		compatible = "hisilicon,hi655x-pmic-driver";
> +		reg = <0x0 0xf8000000 0x0 0x1000>;
> +		#interrupt-cells = <2>;
> +		interrupt-controller;
> +		pmic_gpios = <&gpio_pmu_irq_n>;
> +		status = "okay";
> +	}
> -- 
> 1.9.1
> 
> 

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)