[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20151105141402.GH18409@sirena.org.uk>
Date: Thu, 5 Nov 2015 14:14:02 +0000
From: Mark Brown <broonie@...nel.org>
To: Chen Feng <puck.chen@...ilicon.com>
Cc: w.f@...wei.com, sameo@...ux.intel.com, lee.jones@...aro.org,
linux-kernel@...r.kernel.org, lgirdwood@...il.com,
robh+dt@...nel.org, pawel.moll@....com, mark.rutland@....com,
ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
joro@...tes.org, iommu@...ts.linux-foundation.org,
haojian.zhuang@...aro.org, devicetree@...r.kernel.org,
xuwei5@...ilicon.com, xuyiping@...ilicon.com,
kong.kongxinwei@...ilicon.com, z.liuxinliang@...ilicon.com,
yudongbin@...ilicon.com, weidong2@...ilicon.com,
saberlily.xia@...ilicon.com, haojian.zhuang@...look.com,
leo.yan@...aro.org, linuxarm@...wei.com, dan.zhao@...ilicon.com,
peter.panshilin@...ilicon.com, qijiwen@...ilicon.com
Subject: Re: [PATCH 2/7] doc:bindings:Document for mtcmos regulator on hi6220
SoC
On Thu, Nov 05, 2015 at 09:34:43PM +0800, Chen Feng wrote:
> +- hisilicon,mtcmos-steady-us: The time to wait for power steady
> +- hisilicon,mtcmos-sc-on-base: address of mtcmos on hi6220 SoC
> +
> +Required child device properties:
> +- regulator-name: The name of mtcmos
> +- hisilicon,ctrl-regs: Offset of ctrl-regs
> +- hisilicon,ctrl-data: The bit to ctrl the regulator
This doesn't look like a regulator binding at all... for one thing
there's no reference to the generic regulator bindings, and having a
mandatory regulator-name seems like there's a problem somewhere.
Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)
Powered by blists - more mailing lists