linux-kernel - Re: [PATCH v6] i40e: Look up MAC address in Open Firmware or IDPROM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20151105.133131.1900833527415923596.davem@davemloft.net>
Date:	Thu, 05 Nov 2015 13:31:31 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	andy.shevchenko@...il.com
Cc:	sowmini.varadhan@...cle.com, intel-wired-lan@...ts.osuosl.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	jeffrey.t.kirsher@...el.com, jesse.brandeburg@...el.com,
	shannon.nelson@...el.com, carolyn.wyborny@...el.com,
	donald.c.skidmore@...el.com, matthew.vick@...el.com,
	john.ronciak@...el.com, mitch.a.williams@...el.com
Subject: Re: [PATCH v6] i40e: Look up MAC address in Open Firmware or IDPROM

From: Andy Shevchenko <andy.shevchenko@...il.com>
Date: Thu, 5 Nov 2015 20:13:21 +0200

> What about
> 
> if (!addr)
>  return -ENODATA;

I totally disagree.  of_get_phy_mode() and other similar attribute
probing mechanisms use -ENODEV.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/